Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for non-armored detached signatures #780

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Conversation

smira
Copy link
Contributor

@smira smira commented Sep 25, 2018

Fixes #773

Description of the Change

Seems like some repos start providing non-ASCII armored detached signatures, and aptly has to support them.

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@smira smira added this to the 1.4.0 milestone Sep 25, 2018
@smira smira requested a review from a team September 26, 2018 13:22
@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #780 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #780      +/-   ##
==========================================
+ Coverage   64.05%   64.13%   +0.08%     
==========================================
  Files          50       50              
  Lines        6326     6329       +3     
==========================================
+ Hits         4052     4059       +7     
+ Misses       1778     1776       -2     
+ Partials      496      494       -2
Impacted Files Coverage Δ
pgp/internal.go 47.61% <100%> (+0.63%) ⬆️
pgp/openpgp.go 51.47% <0%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b4a61b...9f7c1f9. Read the comment docs.

Copy link
Contributor

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants