Create extensible Bulk Txn Submit script #13386
Open
+1,563
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 50m total CI duration on this PR
🚨 2 jobs on the last run were significantly faster/slower than expected
|
igor-aptos
force-pushed
the
igor/emitter_changes_for_bulk_submit_script
branch
from
32aac12
to
9b6e945
Compare
Base automatically changed from
igor/emitter_changes_for_bulk_submit_script
to
main
July 2, 2024 17:59
igor-aptos
force-pushed
the
igor/bulk_txn_submit_script
branch
from
e025332
to
27688fa
Compare
bchocho
approved these changes
Aug 5, 2024
| enum DemoCommand { | ||
| Submit(Submit), | ||
| CreateSampleAddresses(CreateSampleAddresses), | ||
| CleanAddresses(CleanAddresses), |
There was a problem hiding this comment.
Perhaps FilterAddresses or SanitizeAddresses? From the command name, I was imagining this somehow "removed" addresses, such as removing balances from all addresses.
| #[derive(Parser, Debug)] | ||
| pub struct CleanAddresses { | ||
| #[clap(long)] | ||
| pub destinations_file: String, |
There was a problem hiding this comment.
destinations_file -> destination_file
|
This issue is stale because it has been open 45 days with no activity. Remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be used for submitting transactions from single account, it can be used for submitting transactions from a pool of worker accounts.
It can be used for submitting list of transactions from a file.
Description
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Key Areas to Review
Checklist