Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Add Copy derive to Monitoring Config. #7656

Merged
merged 1 commit into from
Apr 8, 2023
Merged

[Config] Add Copy derive to Monitoring Config. #7656

merged 1 commit into from
Apr 8, 2023

Conversation

JoshLind
Copy link
Contributor

@JoshLind JoshLind commented Apr 8, 2023

Description

This PR adds the Copy derive to the NodeMonitoringConfig struct to fix a genuine CI/CD semantic merge conflict.

Test Plan

Existing test infrastructure.

@JoshLind JoshLind enabled auto-merge (rebase) April 8, 2023 22:05
@davidiw davidiw disabled auto-merge April 8, 2023 22:07
@davidiw davidiw merged commit 66b91b3 into main Apr 8, 2023
@davidiw davidiw deleted the small_fix branch April 8, 2023 22:07
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

✅ Forge suite land_blocking success on ca874d24d4fbfefb796b004ce83e1919b77a3bc5

performance benchmark with full nodes : 5647 TPS, 7016 ms latency, 9800 ms p99 latency,no expired txns
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> ca874d24d4fbfefb796b004ce83e1919b77a3bc5

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> ca874d24d4fbfefb796b004ce83e1919b77a3bc5 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7823 TPS, 4869 ms latency, 7200 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: ca874d24d4fbfefb796b004ce83e1919b77a3bc5
compatibility::simple-validator-upgrade::single-validator-upgrade : 4888 TPS, 8246 ms latency, 10900 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: ca874d24d4fbfefb796b004ce83e1919b77a3bc5
compatibility::simple-validator-upgrade::half-validator-upgrade : 4390 TPS, 9134 ms latency, 12900 ms p99 latency,no expired txns
4. upgrading second batch to new version: ca874d24d4fbfefb796b004ce83e1919b77a3bc5
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6795 TPS, 5661 ms latency, 9600 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> ca874d24d4fbfefb796b004ce83e1919b77a3bc5 passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

❌ Forge suite framework_upgrade failure on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> ca874d24d4fbfefb796b004ce83e1919b77a3bc5

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> ca874d24d4fbfefb796b004ce83e1919b77a3bc5 (PR)
Upgrade the nodes to version: ca874d24d4fbfefb796b004ce83e1919b77a3bc5
framework_upgrade::framework-upgrade::full-framework-upgrade : 4442 TPS, 5761 ms latency, 8000 ms p99 latency,(!) expired 39178 out of 172460 txns
Test Failed: Unknown error error sending request for url (http://aptos-node-2-validator.forge-framework-upgrade-pr-7656.svc:8080/v1/): error trying to connect: dns error: failed to lookup address information: Name or service not known

Stack backtrace:
   0: <core::result::Result<T,F> as core::ops::try_trait::FromResidual<core::result::Result<core::convert::Infallible,E>>>::from_residual
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/result.rs:2108:27
      aptos_forge::interface::swarm::SwarmExt::fork_check
             at ./testsuite/forge/src/interface/swarm.rs:205:24
   1: <aptos_testcases::framework_upgrade::FrameworkUpgrade as aptos_forge::interface::network::NetworkTest>::run
             at ./testsuite/testcases/src/framework_upgrade.rs:126:9
   2: aptos_forge::runner::Forge<F>::run::{{closure}}
             at ./testsuite/forge/src/runner.rs:397:42
      aptos_forge::runner::run_test
             at ./testsuite/forge/src/runner.rs:464:11
      aptos_forge::runner::Forge<F>::run
             at ./testsuite/forge/src/runner.rs:397:30
   3: forge::run_forge
             at ./testsuite/forge-cli/src/main.rs:334:11
      forge::main
             at ./testsuite/forge-cli/src/main.rs:261:21
   4: core::ops::function::FnOnce::call_once
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/ops/function.rs:251:5
      std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/sys_common/backtrace.rs:121:18
   5: std::rt::lang_start::{{closure}}
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/rt.rs:166:18
   6: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/ops/function.rs:286:13
      std::panicking::try::do_call
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:483:40
      std::panicking::try
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:447:19
      std::panic::catch_unwind
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panic.rs:137:14
      std::rt::lang_start_internal::{{closure}}
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/rt.rs:148:48
      std::panicking::try::do_call
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:483:40
      std::panicking::try
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:447:19
      std::panic::catch_unwind
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panic.rs:137:14
      std::rt::lang_start_internal
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/rt.rs:148:20
   7: main
   8: __libc_start_main
   9: _start
Trailing Log Lines:
      std::panicking::try
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:447:19
      std::panic::catch_unwind
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panic.rs:137:14
      std::rt::lang_start_internal
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/rt.rs:148:20
   7: main
   8: __libc_start_main
   9: _start


Swarm logs can be found here: See fgi output for more information.
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ApiError: namespaces "forge-framework-upgrade-pr-7656" not found: NotFound (ErrorResponse { status: "Failure", message: "namespaces \"forge-framework-upgrade-pr-7656\" not found", reason: "NotFound", code: 404 })

Caused by:
    namespaces "forge-framework-upgrade-pr-7656" not found: NotFound

Stack backtrace:
   0: <core::result::Result<T,F> as core::ops::try_trait::FromResidual<core::result::Result<core::convert::Infallible,E>>>::from_residual
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/result.rs:2108:27
      aptos_forge::backend::k8s::cluster_helper::delete_k8s_cluster::{{closure}}
             at ./testsuite/forge/src/backend/k8s/cluster_helper.rs:278:13
      <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/future/mod.rs:91:19
      aptos_forge::backend::k8s::cluster_helper::uninstall_testnet_resources::{{closure}}
             at ./testsuite/forge/src/backend/k8s/cluster_helper.rs:388:47
      <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/future/mod.rs:91:19
   1: tokio::park::thread::CachedParkThread::block_on::{{closure}}
             at /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.21.2/src/park/thread.rs:267:54
      tokio::coop::with_budget::{{closure}}
             at /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.21.2/src/coop.rs:102:9
      std::thread::local::LocalKey<T>::try_with
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/thread/local.rs:446:16
      std::thread::local::LocalKey<T>::with
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/thread/local.rs:422:9
   2: tokio::coop::with_budget
             at /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.21.2/src/coop.rs:95:5
      tokio::coop::budget
             at /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.21.2/src/coop.rs:72:5
      tokio::park::thread::CachedParkThread::block_on
             at /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.21.2/src/park/thread.rs:267:31
   3: tokio::runtime::enter::Enter::block_on
             at /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.21.2/src/runtime/enter.rs:152:13
      tokio::runtime::scheduler::multi_thread::MultiThread::block_on
             at /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.21.2/src/runtime/scheduler/multi_thread/mod.rs:79:9
   4: tokio::runtime::Runtime::block_on
             at /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.21.2/src/runtime/mod.rs:492:44
   5: <aptos_forge::backend::k8s::swarm::K8sSwarm as core::ops::drop::Drop>::drop
             at ./testsuite/forge/src/backend/k8s/swarm.rs:562:13
   6: core::ptr::drop_in_place<aptos_forge::backend::k8s::swarm::K8sSwarm>
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/ptr/mod.rs:490:1
   7: core::ptr::drop_in_place<alloc::boxed::Box<dyn core::iter::traits::iterator::Iterator+Item = aptos_forge::interface::Version>>
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/ptr/mod.rs:490:1
   8: aptos_forge::runner::Forge<F>::run
             at ./testsuite/forge/src/runner.rs:410:9
   9: forge::run_forge
             at ./testsuite/forge-cli/src/main.rs:334:11
      forge::main
             at ./testsuite/forge-cli/src/main.rs:261:21
  10: core::ops::function::FnOnce::call_once
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/ops/function.rs:251:5
      std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/sys_common/backtrace.rs:121:18
  11: std::rt::lang_start::{{closure}}
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/rt.rs:166:18
  12: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/ops/function.rs:286:13
      std::panicking::try::do_call
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:483:40
      std::panicking::try
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:447:19
      std::panic::catch_unwind
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panic.rs:137:14
      std::rt::lang_start_internal::{{closure}}
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/rt.rs:148:48
      std::panicking::try::do_call
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:483:40
      std::panicking::try
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:447:19
      std::panic::catch_unwind
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panic.rs:137:14
      std::rt::lang_start_internal
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/rt.rs:148:20
  13: main
  14: __libc_start_main
  15: _start', testsuite/forge/src/backend/k8s/swarm.rs:564:18
stack backtrace:
   0: rust_begin_unwind
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:575:5
   1: core::panicking::panic_fmt
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/panicking.rs:65:14
   2: core::result::unwrap_failed
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/result.rs:1791:5
   3: core::result::Result<T,E>::unwrap
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/result.rs:1113:23
   4: <aptos_forge::backend::k8s::swarm::K8sSwarm as core::ops::drop::Drop>::drop
             at ./testsuite/forge/src/backend/k8s/swarm.rs:562:13
   5: core::ptr::drop_in_place<aptos_forge::backend::k8s::swarm::K8sSwarm>
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/ptr/mod.rs:490:1
   6: core::ptr::drop_in_place<alloc::boxed::Box<dyn core::iter::traits::iterator::Iterator+Item = aptos_forge::interface::Version>>
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/ptr/mod.rs:490:1
   7: aptos_forge::runner::Forge<F>::run
             at ./testsuite/forge/src/runner.rs:410:9
   8: forge::run_forge
             at ./testsuite/forge-cli/src/main.rs:334:11
   9: forge::main
             at ./testsuite/forge-cli/src/main.rs:261:21
  10: core::ops::function::FnOnce::call_once
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/ops/function.rs:251:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
Debugging output:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants