Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set packageRules to support github-tags #207

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

suzuki-shunsuke
Copy link
Member

@suzuki-shunsuke suzuki-shunsuke commented Aug 12, 2022

#191

What

  • Update some packages with github-tags datasource
  • Disable github-releases datasource for packages using github-tags datasource to suppress Dependency Lookup Warnings

How

  1. Add RegexManager's Rule to update packages with github-tags datasource
  2. Disable github-tags datasource in aqua.yaml by default
  3. Disable github-releases datasource in aqua.yaml for some packages
  4. Enable github-tags datasource in aqua.yaml for some packages

Test

https://github.com/suzuki-shunsuke/test-renovate/blob/efa495ea1edcda1b55d8053f0b89eccf12388f75/aqua.yaml

The following prs were created.

No warning.

suzuki-shunsuke/test-renovate#106

image

Reference

"golang/go",
"golang/tools",
"kubernetes/kubectl"
],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to manage the list of packages using github-tags datasource.

"aqua.yml"
],
"matchDatasources": ["github-releases"],
"enabled": false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disable github-releases to suppress Dependency Lookup Warnings.

"aqua.yml"
],
"matchDatasources": ["github-tags"],
"enabled": false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disable github-tags datasource by default.

"aqua.yml"
],
"matchDatasources": ["github-tags"],
"enabled": true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enable github-tags datasource for the specific packages.

"golang/tools",
"kubernetes/kubectl"
],
"matchPaths": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this still match a nested aqua.yaml, like foo/bar/aqua.yaml, currently the existing regex "fileMatch": ["\\.?aqua\\.ya?ml"], matches those, I would assume the matchPaths is not needed then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this still match a nested aqua.yaml, like foo/bar/aqua.yaml

Yes. https://docs.renovatebot.com/configuration-options/#matchpaths

This is required to prevent this preset from affecting packages that aren't managed by aqua.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, this is great. I guess this changes also needs to go into file.json

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated file.json too.
453144b

@frezbo
Copy link
Contributor

frezbo commented Aug 12, 2022

Created aquaproj/aqua-registry#5438 for the goimports rename

@suzuki-shunsuke suzuki-shunsuke merged commit 760dc3a into main Aug 12, 2022
@suzuki-shunsuke suzuki-shunsuke deleted the feat/set-package-rules branch August 12, 2022 05:08
@suzuki-shunsuke suzuki-shunsuke added this to the 1.2.3 milestone Aug 12, 2022
@suzuki-shunsuke
Copy link
Member Author

Released. https://github.com/aquaproj/aqua-renovate-config/releases/tag/1.2.3

@suzuki-shunsuke
Copy link
Member Author

Unfortunately, this pr caused a bug #207 , so I'll revert the update of file.json
#212

suzuki-shunsuke added a commit that referenced this pull request Aug 12, 2022
@frezbo
Copy link
Contributor

frezbo commented Aug 12, 2022

Unfortunately, this pr caused a bug #207 , so I'll revert the update of file.json #212

That makes sense, the default still matches most aqua.yaml so I think it's good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants