-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set packageRules to support github-tags #207
Conversation
"golang/go", | ||
"golang/tools", | ||
"kubernetes/kubectl" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to manage the list of packages using github-tags
datasource.
"aqua.yml" | ||
], | ||
"matchDatasources": ["github-releases"], | ||
"enabled": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disable github-releases
to suppress Dependency Lookup Warnings.
"aqua.yml" | ||
], | ||
"matchDatasources": ["github-tags"], | ||
"enabled": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disable github-tags
datasource by default.
"aqua.yml" | ||
], | ||
"matchDatasources": ["github-tags"], | ||
"enabled": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enable github-tags
datasource for the specific packages.
"golang/tools", | ||
"kubernetes/kubectl" | ||
], | ||
"matchPaths": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would this still match a nested aqua.yaml
, like foo/bar/aqua.yaml
, currently the existing regex "fileMatch": ["\\.?aqua\\.ya?ml"],
matches those, I would assume the matchPaths
is not needed then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would this still match a nested aqua.yaml, like foo/bar/aqua.yaml
Yes. https://docs.renovatebot.com/configuration-options/#matchpaths
This is required to prevent this preset from affecting packages that aren't managed by aqua.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, this is great. I guess this changes also needs to go into file.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated file.json too.
453144b
Created aquaproj/aqua-registry#5438 for the |
fix: revert the update of file.json by #207
#191
What
github-tags
datasourcegithub-releases
datasource for packages usinggithub-tags
datasource to suppressDependency Lookup Warnings
How
github-tags
datasourcegithub-tags
datasource in aqua.yaml by defaultgithub-releases
datasource in aqua.yaml for some packagesgithub-tags
datasource in aqua.yaml for some packagesTest
https://github.com/suzuki-shunsuke/test-renovate/blob/efa495ea1edcda1b55d8053f0b89eccf12388f75/aqua.yaml
The following prs were created.
No warning.
suzuki-shunsuke/test-renovate#106
Reference