Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CircleCI renovate config #418

Conversation

akira-kuriyama
Copy link

Hey, thanks for adding the CircleCI support in v1.7.0.

I think the format for aqua orb is like this:

- aqua/aqua:
    version: v2.9.1

In v1.7.0, it seems to me that you're deciding based on a string called 'aqua_version'. But, I'm not sure if it matches the format above.

It might just be a misunderstanding on my part, but I've created a PR for the correction.

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Jul 23, 2023

circleci-orb-aqua 0.3.0 had breaking changes and the parameter name was changed to aqua_version.
https://circleci.com/developer/orbs/orb/aquaproj/aqua#commands-aqua

https://github.com/aquaproj/circleci-orb-aqua/blob/c5ddf2565d2b959f54b4d61349216abeec2234d1/src/commands/aqua.yml#L10-L13

        - aqua/aqua:
            aqua_version: v2.9.1

I found that some examples are wrong.
I'm sorry about that. 🙇‍♂️
I'll fix them.

suzuki-shunsuke added a commit to aquaproj/circleci-orb-aqua that referenced this pull request Jul 23, 2023
suzuki-shunsuke added a commit to aquaproj/circleci-orb-aqua that referenced this pull request Jul 23, 2023
@suzuki-shunsuke
Copy link
Member

Released circleci-orb-aqua 0.3.2 to fix examples.
https://circleci.com/developer/orbs/orb/aquaproj/aqua?version=0.3.2
https://github.com/aquaproj/circleci-orb-aqua/releases/tag/0.3.2

@akira-kuriyama
Copy link
Author

Ah, I see, I understand now.
Thank you for correcting the sample!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants