fix: stop using fromJSON #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`fromJSON` causes a panic if the input isn't JSON. The panic makes the troubleshooting difficult. Especially, if actions are nested you can't understand where and why the panic occurs. So instad of `fromJSON`, we use `== 'true'` and `!= 'true'`.
suzuki-shunsuke
added
bug
suzuki-shunsuke
added a commit
to suzuki-shunsuke/tfaction
that referenced
this pull request
Sep 18, 2023
suzuki-shunsuke
added a commit
to suzuki-shunsuke/tfaction
that referenced
this pull request
Sep 18, 2023
* fix: update update-checksum action - aquaproj/update-checksum-action#39 * debug * fix(get-global-config): fix outputs * fix(get-global-config): make skip_push false in drift detection * fix: output global-config.outputs for troubleshooting * fix: set shell * fix(get-global-config): fix skip_push * fix(setup): output target config for trouble shooting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fromJSONcauses a panic if the input isn't JSON. The panic makes the troubleshooting difficult.Especially, if actions are nested you can't understand where and why the panic occurs.
So instad of
fromJSON, we use== 'true'and!= 'true'.