HOMEWORK bobocode-projects#12 – Java Networking

aquariusmaster · aquariusmaster · commit d0c5b2e0c2e8 · 2021-09-30T22:55:47.000+03:00
- refactor
diff --git a/lesson-demo/src/main/java/com/bobocode/lesson12/HM12.java b/lesson-demo/src/main/java/com/bobocode/lesson12/HM12.java
@@ -10,8 +10,11 @@
 import java.util.Objects;
 
 import static com.bobocode.HTTPGet.parseImageUrls;
+import static java.lang.Long.parseLong;
 import static java.net.http.HttpRequest.BodyPublishers.noBody;
 import static java.util.Comparator.comparingLong;
+import static java.util.Objects.nonNull;
+import static java.util.Objects.requireNonNull;
 
 public class HM12 {
 
@@ -22,33 +25,29 @@ public static void main(String[] args) {
         parseImageUrls(get(link).body())
                 .parallelStream()
                 .map(HM12::get)
-                .filter(res -> Objects.nonNull(getHeader(res, "Location")))
+                .filter(res -> nonNull(getHeader(res, "Location")))
                 .map(res -> getHeader(res, "Location"))
                 .map(HM12::head)
-                .filter(res -> Objects.nonNull(getHeader(res, "Content-Length")))
-                .max(comparingLong(res -> Long.parseLong(getHeader(res, "Content-Length"))))
+                .max(comparingLong(res -> parseLong(requireNonNull(getHeader(res, "Content-Length")))))
                 .ifPresent(res -> System.out.printf("%s - length: %s", res.uri(), getHeader(res, "Content-Length")));
     }
 
     @SneakyThrows
-    public static HttpResponse<String> get(String link) {
-        return exchange(link, "GET", noBody());
-    }
-
-    @SneakyThrows
-    public static HttpResponse<String> head(String link) {
-        return exchange(link, "HEAD", noBody());
-    }
-
-    @SneakyThrows
-    public static HttpResponse<String> exchange(String link, String method, HttpRequest.BodyPublisher bodyPublisher) {
+    private static HttpResponse<String> exchange(String link, String method, HttpRequest.BodyPublisher bodyPublisher) {
         var request = HttpRequest.newBuilder(new URI(link)).method(method, bodyPublisher).build();
         return httpClient.send(request, HttpResponse.BodyHandlers.ofString());
     }
 
     private static String getHeader(HttpResponse<String> response, String header) {
-        Objects.requireNonNull(response);
         List<String> values = response.headers().map().get(header);
         return values == null || values.isEmpty() ? null : values.get(0);
     }
+
+    private static HttpResponse<String> get(String link) {
+        return exchange(link, "GET", noBody());
+    }
+
+    private static HttpResponse<String> head(String link) {
+        return exchange(link, "HEAD", noBody());
+    }
 }
