Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need ability to annotate services #92

Closed
kcorupe opened this issue Jun 23, 2020 · 4 comments
Closed

Need ability to annotate services #92

kcorupe opened this issue Jun 23, 2020 · 4 comments

Comments

@kcorupe
Copy link
Contributor

kcorupe commented Jun 23, 2020

AWS requires annotation of services for certain configurations as an example requirement.

This PR was closed that added that functionality without comment.

#79

Example:

  grpcservice:
    annotations:
      external-dns.alpha.kubernetes.io/hostname: aqua-gateway.company.domain
      service.beta.kubernetes.io/aws-load-balancer-internal: 0.0.0.0/0
@agilgur5
Copy link
Contributor

#58 was also closed without comment

@agilgur5
Copy link
Contributor

And #95 had a commit adding annotations and was just closed without comment as well...

@rshmiel
Copy link
Contributor

rshmiel commented Dec 17, 2020

all!
Sorry for the bad communication around this issue and PR, it wont be like that from now on.
Closing this issue.

@rshmiel rshmiel closed this as completed Dec 17, 2020
@agilgur5
Copy link
Contributor

It was multiple PRs. But you also closed this without saying whether or how it's been resolved, which is not much different from how it was...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants