Allow common image tag

[Hefeweizen]

I expect to keep all the images in lockstep, so specifying tag versions separately seems an anti-pattern. This change allows them to be easily kept in sync by taking their common config value from one line. It retains the ability to set them separately if needed.

[cdunford]

One thing you could consider (I've seen done in other charts and have done myself in some) is falling back to use .Chart.AppVersion as the image tag if not overridden. Conceptually it makes sense to me.

[Hefeweizen]

One thing you could consider (I've seen done in other charts and have done myself in some) is falling back to use .Chart.AppVersion as the image tag if not overridden. Conceptually it makes sense to me.

Great idea! I like it; let's use preexisting info wherever possible. But, help me talk this through a little bit. The major version is staying the same, and I'm bumping via Update Releases (https://docs.aquasec.com/docs/update-releases). So, as a user should I be modifying Charts.yaml with that specific version (e.g. 5.0.20190), or would I be able to set .chart.appversion in values.yaml. Because, as an end-user, I would only ever expect to update the values.yaml file (chart.yaml is metadata set by the packager, not information I'm picking).

[cdunford]

Yes you're right; the user wouldn't change Chart.yaml - I think your change still makes sense to allow the user to change all tags at once. I think the benefit of falling back to .Chart.AppVersion is the chart doesn't need to specify a .Values.common.image.tag by default and instead uses the standard AppVersion.

[niso120b]

not relevant based on the helm chart design

[cdunford]

@niso120b - do you have more information on what is "not relevant"?

[agilgur5]

Seems like it is pretty common for useful PRs (and issues) to be closed here with little or no comment, as was in my #99 (comment) and in several examples listed in #92