Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when the sub group has the same name as the repository #130

Closed
codekuu opened this issue Oct 26, 2023 · 0 comments · Fixed by #132
Closed

Issue when the sub group has the same name as the repository #130

codekuu opened this issue Oct 26, 2023 · 0 comments · Fixed by #132

Comments

@codekuu
Copy link
Contributor

codekuu commented Oct 26, 2023

Description

Issue when the sub group has the same name as the repository.
Example: https://my-gitlab-instance.com/top-group/sub-group/repo-name/repo-name

getRepoInfo returns:

host: my-gitlab-instance.com
namespace: top-group/sub-group
repo: repo-name
err: %!s(<nil>)

What did you expect to happen?

should return:

host: my-gitlab-instance.com
namespace: top-group/sub-group/repo-name
repo: repo-name
err: %!s(<nil>)

What happened instead?

getRepoInfo returns:

host: my-gitlab-instance.com
namespace: top-group/sub-group
repo: repo-name
err: %!s(<nil>)

Made a PR for this but due to the contribution guidelines I created this issue as well.

morwn added a commit that referenced this issue Oct 31, 2023
* Fixed issue related to #130

* Adding test coverage

* Fixed test for clients

Changed BaseURL in test from gitlab to github.

* Update internal/scm-clients/clients/clients_test.go

Co-authored-by: Mor Weinberger <morwnbrg@gmail.com>

* Update internal/scm-clients/clients/clients_test.go

Co-authored-by: Mor Weinberger <morwnbrg@gmail.com>

* Update internal/scm-clients/clients/clients_test.go

Co-authored-by: Mor Weinberger <morwnbrg@gmail.com>

---------

Co-authored-by: Mor Weinberger <morwnbrg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant