Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Severity mapping to controls #94

Merged
merged 2 commits into from
Oct 23, 2022
Merged

Severity mapping to controls #94

merged 2 commits into from
Oct 23, 2022

Conversation

resheetk
Copy link
Contributor

Description

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the readme with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@resheetk resheetk requested a review from morwn October 20, 2022 15:00
@morwn morwn merged commit 9ef4074 into morwn/gitlab_support Oct 23, 2022
@morwn morwn deleted the severity-with-gitlab branch October 23, 2022 15:21
MorAlon1 pushed a commit that referenced this pull request Oct 25, 2022
@morwn @resheetk
Add Support for Gitlab (#97)
9fc6767 
* support gitlab provider part 1

* comment out unsupported field

* template format reporting

* filter unsupported checks

* filter out non failed checks

* add severity

* add gitlab mapper unit test

* add gitlab scanner alias and doc

* doc for creating access token

* Severity mapping to controls (#94)

* severity mapping

* fixes

* align with client adapter interface

* filter out unsupported checks per provider

Co-authored-by: resheetk <108011346+resheetk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morwn morwn morwn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@resheetk @morwn