Fix missing dependencies and refactor to really prevent in the future #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test that runs almost all imports
|
I suspect that travis is not running all tests, but I propose to address that after pull request #185 since that also modifies the travis integration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@matthewdfuller
A recent commit broke dependencies - @octocat/app is now required, but it is not in package.json.
This change adds that dependency and moves some code to a function so that nearly everything is callable from a test. I verified that the test fails if the dependency is not defined, so I'm certain that this will substantially reduce the risk in the future.
The moved code has no functional changes - it is just moved so that I can call from a unit test. However, this change is useful for the future so that it's possible to write more comprehensive tests.