feat: Show color badges for severity on reports lists #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
danielpacak
suggested changes
Apr 22, 2022
There was a problem hiding this comment.
Great idea @nublarsec and thanks for working on the implementation. I left minor comments to apply. I also noticed that the text is not exactly centered.
|
@danielpacak thanks for the quick reply. I've dropped the unused severity styles. I also changed the badges for zero counts so they still appear with the same size and shape. This looks better and keeps all the counts aligned. |
danielpacak
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds color badges to the severity counts on the report list pages, making them easier to scan visually.
This resolves issue #83.
Vulnerability Reports page:
Config Audit Reports page:
CIS Kube Bench Reports page:
