fix(polaris): Remove clutter from JSON output #493
Conversation
Resolves: #449 Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
| @@ -9,8 +9,7 @@ import ( | |||
| "github.com/aquasecurity/starboard/pkg/ext" | |||
| "github.com/aquasecurity/starboard/pkg/plugin/polaris" | |||
| "github.com/aquasecurity/starboard/pkg/starboard" | |||
| "github.com/stretchr/testify/assert" | |||
| "github.com/stretchr/testify/require" | |||
| "github.com/onsi/gomega" | |||
There was a problem hiding this comment.
On the mission to replace Testify with Gomega matchers, which are more powerful and we use them in integration tests.
There was a problem hiding this comment.
Fireside chat: I get the reasoning but I personally would still vote for testify just because I find them simpler to write. gexec is great though for integration tests.
There was a problem hiding this comment.
With testify I struggled many times to assert on complex objects / object trees in unit tests. Only Gomega allowed me to do so. On the other hand keeping and learning 2 assert libraries doesn't really make sense from maintenance stand point. But we can think about it and vote what would be the best option.
| "--config", "/etc/starboard/polaris.config.yaml", | ||
| "--resource", "default/Deployment.apps/v1/nginx", | ||
| "-c", | ||
| "polaris audit --log-level error --config /etc/starboard/polaris.config.yaml --resource default/Deployment.apps/v1/nginx 2> /dev/null", |
There was a problem hiding this comment.
2> /dev/null to get rid of logs from clinet-go, e.g. rate limit warnings
Codecov Report
@@ Coverage Diff @@
## main #493 +/- ##
==========================================
- Coverage 70.25% 69.96% -0.30%
==========================================
Files 62 62
Lines 3994 3992 -2
==========================================
- Hits 2806 2793 -13
- Misses 892 900 +8
- Partials 296 299 +3
Continue to review full report at Codecov.
|
Resolves: #449
Signed-off-by: Daniel Pacak pacak.daniel@gmail.com