Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3771
This PR fixes the parsing of types on arguments (signatures) that aren't supported by grpc event data. The idea is that users can create signature and pass whatever information as
finding.Data
to fit their needs, but this information must be converted properly to protobuf so the GRPC api can return it when streaming events.I've tried a few solutions, but it always endup using reflection if tracee was the one responsible to convert the type, which is slow and cubersome, for example, we are only able to read exported fields, nested need deeper logic for convertion. So instead a better solution is to ask the user which information he wants to send on the grpc by implementing an interface, if the interface is implemented tracee calls it and use that data for the argument (kuddos to @NDStrahilevitz for the idea).
Also, we don't break the logic anymore if we can't parse an argument, we log and send the event with the missing data if needed.
Depends
#3776