Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Struct type and detect.FindingData #3776

Merged
merged 2 commits into from Dec 22, 2023
Merged

add Struct type and detect.FindingData #3776

merged 2 commits into from Dec 22, 2023

Conversation

josedonizetti
Copy link
Collaborator

@josedonizetti josedonizetti commented Dec 20, 2023 •
edited

This PRs:

  • adds a new type to grpc event data, which is used to convert dynamic types not supported by event data
  • adds an interface, which should be implemented for the conversion mentioned aboce to succeeded

@josedonizetti
feature: add dynamic struct to event_data
bed6ae7
@josedonizetti
feature: add FindingData interface
c0a887f 
The FindingData interface can be implemented whenever an argument type
isn't supported by the grpc event_data
@josedonizetti josedonizetti changed the title Fix dynamic data arguments1 Fix dynamic data arguments Dec 20, 2023
@josedonizetti josedonizetti mentioned this pull request Dec 20, 2023
Merged
@josedonizetti josedonizetti changed the title Fix dynamic data arguments add Struct type and detect.FindingData Dec 20, 2023
@josedonizetti josedonizetti marked this pull request as ready for review December 20, 2023 13:47
@NDStrahilevitz
Copy link
Collaborator

@AlonZivony FYI once we merge this we should implement the interface internally.

yanivagman
yanivagman approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josedonizetti josedonizetti merged commit 0f73aad into aquasecurity:main Dec 22, 2023
31 checks passed
@josedonizetti josedonizetti deleted the fix-dynamic-data-arguments1 branch December 22, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanivagman yanivagman yanivagman approved these changes

@NDStrahilevitz NDStrahilevitz Awaiting requested review from NDStrahilevitz

Assignees

@josedonizetti josedonizetti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@josedonizetti @NDStrahilevitz @yanivagman