Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e-net-tests should use unified binary #3842

Merged

Conversation

josedonizetti
Copy link
Contributor

@josedonizetti josedonizetti commented Feb 1, 2024

Fixing e2e tests to use the tracee binary instead of tracee-rules and tracee-ebpf.

tests/e2e-kernel-test.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@NDStrahilevitz NDStrahilevitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please fix the commented area before merging.

Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, put a request related to missing \ and commented other stuff.

tests/e2e-kernel-test.sh Outdated Show resolved Hide resolved
tests/e2e-kernel-test.sh Outdated Show resolved Hide resolved
@josedonizetti josedonizetti merged commit 9ff652e into aquasecurity:main Feb 12, 2024
32 checks passed
@josedonizetti josedonizetti deleted the e2e-tests-should-single-binary branch February 12, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants