-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: e2e-net-tests should use unified binary #3842
Merged
josedonizetti
merged 5 commits into
aquasecurity:main
from
josedonizetti:e2e-tests-should-single-binary
Feb 12, 2024
Merged
fix: e2e-net-tests should use unified binary #3842
josedonizetti
merged 5 commits into
aquasecurity:main
from
josedonizetti:e2e-tests-should-single-binary
Feb 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josedonizetti
force-pushed
the
e2e-tests-should-single-binary
branch
from
February 1, 2024 22:12
7270d53
to
3d25492
Compare
josedonizetti
force-pushed
the
e2e-tests-should-single-binary
branch
from
February 1, 2024 23:34
32c9b68
to
9ab9c3a
Compare
josedonizetti
force-pushed
the
e2e-tests-should-single-binary
branch
from
February 1, 2024 23:40
9ab9c3a
to
2b553d2
Compare
yanivagman
reviewed
Feb 4, 2024
NDStrahilevitz
approved these changes
Feb 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please fix the commented area before merging.
josedonizetti
force-pushed
the
e2e-tests-should-single-binary
branch
from
February 4, 2024 14:14
fee6efc
to
5217b79
Compare
geyslan
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, put a request related to missing \ and commented other stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing e2e tests to use the
tracee
binary instead oftracee-rules
andtracee-ebpf
.