Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove gob printer #3841

Merged
merged 1 commit into from
Feb 17, 2024
Merged

chore: remove gob printer #3841

merged 1 commit into from
Feb 17, 2024

Conversation

josedonizetti
Copy link
Contributor

@josedonizetti josedonizetti commented Feb 1, 2024 •
edited
Loading

Remove the gob printer. This is a legacy printer which was used by tracee-rules and tracee-ebpf, which are no longer supported and will be soon removed from the repo.

@josedonizetti
Copy link
Contributor Author

depends on #3842

@josedonizetti josedonizetti force-pushed the remove-gob-printer branch 2 times, most recently from c4f4e78 to c8c8cf1 Compare February 12, 2024 22:27
@aqua-ci
Copy link

aqua-ci commented Feb 12, 2024

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0564e75d9605addaf_3841-7878755854_01' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

1 similar comment
@aqua-ci
Copy link

aqua-ci commented Feb 13, 2024

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0564e75d9605addaf_3841-7878755854_01' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@geyslan
Copy link
Member

geyslan commented Feb 14, 2024

depends on #3842

It was already merged. Let's get rid of gob (finally 😀)?

@josedonizetti josedonizetti force-pushed the remove-gob-printer branch 2 times, most recently from c8c8cf1 to 371b925 Compare February 14, 2024 21:39
@josedonizetti josedonizetti linked an issue Feb 14, 2024 that may be closed by this pull request
Fix Gob Output Doc #3471
Closed
@josedonizetti josedonizetti marked this pull request as ready for review February 14, 2024 22:26
geyslan
geyslan approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aqua-ci
Copy link

aqua-ci commented Feb 16, 2024

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-040d4dc2758203717_3841-7930934988_01' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@aqua-ci
Copy link

aqua-ci commented Feb 16, 2024

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0d9d35323406a6cad_3841-7930934988_01' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@aqua-ci
Copy link

aqua-ci commented Feb 16, 2024

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-040d4dc2758203717_3841-7930934988_01' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@aqua-ci
Copy link

aqua-ci commented Feb 16, 2024

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0d9d35323406a6cad_3841-7930934988_01' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

1 similar comment
@aqua-ci
Copy link

aqua-ci commented Feb 16, 2024

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0d9d35323406a6cad_3841-7930934988_01' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@aqua-ci
Copy link

aqua-ci commented Feb 16, 2024

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-040d4dc2758203717_3841-7930934988_01' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@aqua-ci
Copy link

aqua-ci commented Feb 16, 2024

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-040d4dc2758203717_3841-7930934988_01' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@aqua-ci
Copy link

aqua-ci commented Feb 16, 2024

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0d9d35323406a6cad_3841-7930934988_01' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

1 similar comment
@aqua-ci
Copy link

aqua-ci commented Feb 17, 2024

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0d9d35323406a6cad_3841-7930934988_01' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@josedonizetti josedonizetti merged commit 9c56a31 into aquasecurity:main Feb 17, 2024
30 of 32 checks passed
@josedonizetti josedonizetti deleted the remove-gob-printer branch February 17, 2024 11:21
@aqua-ci
Copy link

aqua-ci commented Feb 17, 2024

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-040d4dc2758203717_3841-7930934988_01' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@geyslan geyslan mentioned this pull request Mar 27, 2024
Closed
geyslan added a commit to geyslan/tracee that referenced this pull request Mar 27, 2024
@geyslan
chore!: remove gob support from tracee-rules
ec64498 
This finishes the removal of gob support after aquasecurity#3841.
geyslan added a commit that referenced this pull request Apr 1, 2024
@geyslan
chore!: remove gob support from tracee-rules (#3939)
dd02740 
This finishes the removal of gob support after #3841.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geyslan geyslan geyslan approved these changes

@yanivagman yanivagman Awaiting requested review from yanivagman

Assignees

@josedonizetti josedonizetti

Labels
area/flags area/signatures area/testing area/UX kind/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Gob Output Doc
4 participants
@josedonizetti @aqua-ci @geyslan @yanivagman