-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(go): updates wazero to 1.0.0-pre.7 #3355
chore(go): updates wazero to 1.0.0-pre.7 #3355
Conversation
@knqyf263 do I understand trivy builds for linux_386 as in 32-bit linux? We are currently failing to build for that architecture, as we aren't testing it. I guess we could in a future version, stub it out? wdyt?
cc @mathetake |
Doesn't the wazero intepretor work on Linux 32 bit? |
This updates to wazero v1.0.0-pre.7 which fixes a `GOARCH=386` compilation problem in v1.0.0-pre.6. This updates [wazero](https://wazero.io/) to [v1.0.0-pre.6](https://github.com/tetratelabs/wazero/releases/tag/v1.0.0-pre.6). Notably, v1.0.0-pre.6: * improves module compilation and initialization performance * adds `writefs.NewDirFS` which lets you add new files. * `path_open` `O_CREAT` flags, `path_remove_directory` `path_rename` `path_unlink_file` * adds `NewFilesystemLoggingListenerFactory` with dramatically improved logging. This also includes changes described in [v1.0.0-pre.5](https://github.com/tetratelabs/wazero/releases/tag/v1.0.0-pre.5). Notably, context param was removed from memory functions as it was never used due to the scope being very narrow, and adds overhead to propagate. Signed-off-by: Adrian Cole <adrian@tetrate.io>
602bf6f
to
e11d9b0
Compare
Interpreter itself should work for sure, just that we don't test it and maybe some platform specific thing in WASI might need some fix |
Recently, we are completing filesystem write support, which is independent of the wasm core which is only about the engine (interpreter vs compiler). In this PR we noticed we didn't have a build check to ensure 386 builds. Mainly I was curious about if this is actually a runtime of trivy, or if it was something just there to avail all things. In any case, when looking at the impact of the filesystem if 386 it was easy enough to work around for now. Anyway, the main issue was we weren't testing on compilation of 386 and so didn't notice until this PR anyone was depending on that. We won't be doing runtime tests on the cartesian product of all possible GOOS GOARCH, probably for the same reason you don't. For now, we have to assume that 386 platform works if you can compile it. Anyway I cut a patch release for 386 so this PR should be good to go, now! |
There are not so many users, but not zero. It would be better to keep providing these binaries.
Fair enough. Let's see how it goes.
Thanks👍 |
Signed-off-by: Adrian Cole <adrian@tetrate.io>
Description
This updates to wazero v1.0.0-pre.7 which fixes a
GOARCH=386
compilation problem in v1.0.0-pre.6.wazero 1.0.0-pre.6 includes the following notable changes:
The following features are new and not currently used in Trivy, but might be relevant for future work:
writefs.NewDirFS
which lets you add new files.path_open
O_CREAT
flags,path_remove_directory
path_rename
path_unlink_file
NewFilesystemLoggingListenerFactory
with dramatically improved logging.This also includes changes described in 1.0.0-pre.5. Notably, context param was removed from memory functions as it was never used due to the scope being very narrow, and adds overhead to propagate.