Ensures 32-bit platforms build #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codefromthecrypt
commented
Jan 1, 2023
| @@ -213,6 +213,7 @@ format: | |||
| .PHONY: check | |||
| check: | |||
| @GOARCH=amd64 GOOS=dragonfly go build ./... # Check if the internal/platform can be built on compiler-unsupported platforms | |||
| @GOARCH=386 GOOS=linux go build ./... # Check if the internal/platform can be built on compiler-unsupported platforms | |||
There was a problem hiding this comment.
this is the missing check, though theoretically we could fail on the various flavors of 32-bit arm or powerpc
Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
commented
Jan 1, 2023
| return syscall.UtimesNano(path.Join(string(dir), name), []syscall.Timespec{ | ||
| {Sec: atimeSec, Nsec: atimeNsec}, | ||
| {Sec: mtimeSec, Nsec: mtimeNsec}, | ||
| syscall.NsecToTimespec(atimeNsec), |
There was a problem hiding this comment.
the key is using this which implicitly coerces 64 bit to 32bit as needed.
mathetake
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivy builds with linux_386, so this adds a check to ensure we cover 386 arch even if it may or may not work in interpreter (definitely not in compiler)
See aquasecurity/trivy#3355