PE-4903 - parallel unbundling #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users adjust the nodejs GC max old gen size. This can help avoid out of memory crashes when running a lot of workers to process GraphQL queries or do unbundling. This also raises the default to 2GB from 512MB.
Defaulting to the number of CPU cores is fine until you have 128 cores. Then you run out of memory. :) This limits the max SQLite GQL workers to 12 with the number of CPU cores as the default below 12. In the future we may make this configurable.
Adds worker threads to the Ans104Parser implemented in a similar fashion to the SQLite workers. There is a fixed size worker pool. Each worker takes work as it becomes available, processes it, and then repeats. Callers block until work is complete. The number of workers defaults to 2 but is configurable via the ANS104_UNBUNDLE_WORKERS environment variable. Along with this change, The number of data item indexing workers is increased from 1 to 2 to help ensure that communication round tip latency between the main thread the DB threads is not the bottleneck for data item indexing.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #65 +/- ##
===========================================
- Coverage 57.72% 57.26% -0.47%
===========================================
Files 18 18
Lines 5280 5335 +55
Branches 260 260
===========================================
+ Hits 3048 3055 +7
- Misses 2228 2276 +48
Partials 4 4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds worker threads to the Ans104Parser implemented in a similar fashion to the SQLite workers. There is a fixed size worker pool. Each worker takes work as it becomes available, processes it, and then repeats. Callers block until work is complete. The number of workers defaults to 2 but is configurable via the ANS104_UNBUNDLE_WORKERS environment variable. Along with this change, The number of data item indexing workers is increased from 1 to 2 to help ensure that communication round tip latency between the main thread the DB threads is not the bottleneck for data item indexing.