feat(lmdb): use lmdb for contract cache #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LMDB cache is more reliable than level db, particulary with the arns contract. Also includes an update to typescript to avoid unnecessary workarounds loading the CJS module in this project. There are some suggestions we can offer to their module that would also help.
dtfiedler
force-pushed
the
PE-5507-lmdb-cache
branch
from
0702675
to
683522d
Compare
djwhitt
approved these changes
Jan 26, 2024
|
@dtfiedler Oops, I was a little too hasty on the approve. Looks like there's a build issue. |
…s named exports, so we are stuck telling tyepscript where to find them manually. This can be removed when their library is updated.
|
@djwhitt - referenced the issue in the commit message, their package doesn't specify types in the named export so we need a workaround until this gets merged and released warp-contracts/warp-contracts-lmdb#27. I offered the fix here warp-contracts/warp-contracts-lmdb#28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LMDB cache is more performant than LevelDB, particulary with the arns contract's large interaction count. This change also includes an update to
tsconfig.jsonto get around loading the improperly exported types. There are some suggestions we can offer to their module that would also help.