feat(ao): use IO/AO contract from ar.io/sdk #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 5, 2024 13:27
This includes fetching prescribed names directly from the contract rather than computing them internally.
…oosen names, update implementations to use the sdk
… block height from contract
dtfiedler
commented
Jun 7, 2024
added 3 commits
June 7, 2024 06:39
…ntion to avoid collisions. This is to be consistent with previous naming conventions for report filenames, but it is important to note the epochStartHeight is provided by the contract for the epoch and not computed by the observer
dtfiedler
commented
Jun 7, 2024
| GatewayAssessments, | ||
| GatewayHostsSource, | ||
| ObserverReport, | ||
| OwnershipAssessment, | ||
| } from './types.js'; | ||
|
|
||
| const REPORT_FORMAT_VERSION = 1; | ||
| export const REPORT_FORMAT_VERSION = 2; |
There was a problem hiding this comment.
@djwhitt - is the report format intended to reflect just the assessments? I've changed the top level attributes to include epochStartTimestamp and epochEndTimestamp. We can revert it back to 1 if the bump is not necessary.
There was a problem hiding this comment.
Yeah, you're doing the right thing. We should bump the version for this.
added 2 commits
June 10, 2024 20:40
…contract Since we are not computing epochs ourselves, we need to fetch the epoch information from the contract when we run a new report. This moves that logic to a class that fetches epoch information on every execution of running a report. It will cache the result until the epoch is over, based on network time rather than local system time.
dtfiedler
requested review from
djwhitt and
karlprieb
and removed request for
djwhitt
added 7 commits
June 11, 2024 09:36
The newer release of arweave 2.7+ shortened the max fork depth to 18 blocks.
It is used for both prescribed and chosen names so keeping it general makes sense.
We were not passing the height around so the choseNames kept returning an empty array
djwhitt
approved these changes
Jun 11, 2024
| } | ||
|
|
||
| async getName(height: number, index: number): Promise<string> { | ||
| const names = await this.getAllNames(height); |
There was a problem hiding this comment.
Fine for now (basically what we did before I think), but we'll need a more efficient way to do this in a future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes fetching prescribed names and epoch information directly from the contract rather than computing them internally (PE-6259).
Logs:
info: Using wallet 1H7WZIWhzwTH9FIcnuMqYkTsoyv1OTfGa_amvuYwrgo {"timestamp":"2024-06-11T16:31:29.892Z"} info: Loading key file... {"keyFile":"./wallets/1H7WZIWhzwTH9FIcnuMqYkTsoyv1OTfGa_amvuYwrgo.json","timestamp":"2024-06-11T16:31:29.895Z"} info: Key file loaded {"keyFile":"./wallets/1H7WZIWhzwTH9FIcnuMqYkTsoyv1OTfGa_amvuYwrgo.json","timestamp":"2024-06-11T16:31:29.896Z"} info: Using process GaQrvEMKBpkjofgnBi_B3IgIDmY_XYelVLB6GcRGrHc to fetch contract information {"processId":"GaQrvEMKBpkjofgnBi_B3IgIDmY_XYelVLB6GcRGrHc","timestamp":"2024-06-11T16:31:29.911Z"} info: Generating report... {"timestamp":"2024-06-11T16:31:29.941Z"} info: Listening on port 4000 {"timestamp":"2024-06-11T16:31:29.949Z"} info: Fetched epoch params {"class":"ContractEpochSource","endTimestamp":1718150400000,"epochIndex":19885,"startHeight":1442178,"startTimestamp":1718064000000,"timestamp":"2024-06-11T16:31:31.044Z"} info: Report generated in 21223ms {"timestamp":"2024-06-11T16:31:51.164Z"} info: Report cached {"timestamp":"2024-06-11T16:31:51.166Z"} info: Getting observers from contract state... {"timestamp":"2024-06-11T16:31:51.166Z"} info: Retrieved 13 observers from contract state {"timestamp":"2024-06-11T16:31:51.832Z"} info: Saving report... {"class":"PipelineReportSink","epochIndex":19885,"epochStartHeight":1442178,"epochStartTimestamp":1718064000000,"timestamp":"2024-06-11T16:31:52.432Z"} info: Saving report using FsReportStore... {"class":"PipelineReportSink","epochIndex":19885,"epochStartHeight":1442178,"epochStartTimestamp":1718064000000,"timestamp":"2024-06-11T16:31:52.432Z"} info: Using previously saved report {"class":"FsReportStore","epochIndex":19885,"epochStartHeight":1442178,"epochStartTimestamp":1718064000000,"timestamp":"2024-06-11T16:31:52.433Z"} info: Report saved using FsReportStore {"class":"PipelineReportSink","epochIndex":19885,"epochStartHeight":1442178,"epochStartTimestamp":1718064000000,"timestamp":"2024-06-11T16:31:52.433Z"} info: Saving report using TurboReportSink... {"class":"PipelineReportSink","epochIndex":19885,"epochStartHeight":1442178,"epochStartTimestamp":1718064000000,"timestamp":"2024-06-11T16:31:52.433Z"} info: Report already saved, skipping upload {"class":"TurboReportSink","epochIndex":19885,"epochStartHeight":1442178,"epochStartTimestamp":1718064000000,"timestamp":"2024-06-11T16:31:52.717Z"} info: Report saved using TurboReportSink {"class":"PipelineReportSink","epochIndex":19885,"epochStartHeight":1442178,"epochStartTimestamp":1718064000000,"reportTxId":"ekhAZcWztsh2pvialVYwnPCDY8oaXwx_CJgMdgWPYgc","timestamp":"2024-06-11T16:31:52.717Z"} info: Saving report using ContractReportSink... {"class":"PipelineReportSink","epochIndex":19885,"epochStartHeight":1442178,"epochStartTimestamp":1718064000000,"timestamp":"2024-06-11T16:31:52.717Z"} info: Saving observation interactions... {"timestamp":"2024-06-11T16:31:53.070Z"} info: Observation interactions saved {"interactionIds":["DzaOu1L8PmM1TX9eh9sEpkPBQygBbaI4-Zupgcaa8iE"],"timestamp":"2024-06-11T16:31:53.725Z"} info: Report saved using ContractReportSink {"class":"PipelineReportSink","epochIndex":19885,"epochStartHeight":1442178,"epochStartTimestamp":1718064000000,"interactionTxIds":["DzaOu1L8PmM1TX9eh9sEpkPBQygBbaI4-Zupgcaa8iE"],"reportTxId":"ekhAZcWztsh2pvialVYwnPCDY8oaXwx_CJgMdgWPYgc","timestamp":"2024-06-11T16:31:53.725Z"}Report
{ "formatVersion": 2, "observerAddress": "1H7WZIWhzwTH9FIcnuMqYkTsoyv1OTfGa_amvuYwrgo", "epochIndex": 19885, "epochStartTimestamp": 1718064000000, "epochStartHeight": 1442178, "epochEndTimestamp": 1718150400000, "generatedAt": 1718123240, "gatewayAssessments": { "permaweb.name": { "ownershipAssessment": { "expectedWallets": [ "M0WP8KSzCvKpzC-HPF1WcddLgGaL9J4DGi76iMnhrN4" ], "observedWallet": null, "failureReason": "certificate has expired", "pass": false }, "arnsAssessments": { "prescribedNames": { "ar-io": { "assessedAt": 1718123228, "expectedId": null, "resolvedId": null, "expectedDataHash": null, "resolvedDataHash": null, "failureReason": "certificate has expired", "pass": false }, "chicapowa": { "assessedAt": 1718123228, "expectedId": null, "resolvedId": null, "expectedDataHash": null, "resolvedDataHash": null, "failureReason": "certificate has expired", "pass": false }, "paulsan": { "assessedAt": 1718123228, "expectedId": null, "resolvedId": null, "expectedDataHash": null, "resolvedDataHash": null, "failureReason": "certificate has expired", "pass": false }, "perma-user-gi": { "assessedAt": 1718123228, "expectedId": null, "resolvedId": null, "expectedDataHash": null, "resolvedDataHash": null, "failureReason": "certificate has expired", "pass": false }, "permabuy": { "assessedAt": 1718123228, "expectedId": null, "resolvedId": null, "expectedDataHash": null, "resolvedDataHash": null, "failureReason": "certificate has expired", "pass": false } }, "chosenNames": { "somenewdomain": { "assessedAt": 1718123228, "expectedId": null, "resolvedId": null, "expectedDataHash": null, "resolvedDataHash": null, "failureReason": "certificate has expired", "pass": false }, "fixyfixfix4": { "assessedAt": 1718123228, "expectedId": null, "resolvedId": null, "expectedDataHash": null, "resolvedDataHash": null, "failureReason": "certificate has expired", "pass": false }, "jiggyhunt": { "assessedAt": 1718123229, "expectedId": null, "resolvedId": null, "expectedDataHash": null, "resolvedDataHash": null, "failureReason": "certificate has expired", "pass": false }, "giggitygiggitygoo": { "assessedAt": 1718123229, "expectedId": null, "resolvedId": null, "expectedDataHash": null, "resolvedDataHash": null, "failureReason": "certificate has expired", "pass": false }, "testtickauction": { "assessedAt": 1718123229, "expectedId": null, "resolvedId": null, "expectedDataHash": null, "resolvedDataHash": null, "failureReason": "certificate has expired", "pass": false } }, "pass": false }, "pass": false },Contract:
Using
networkContract.getEpoch({ epochIndex: 19885 })