Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEBHOOKS] Some events should not trigger mark as unplayed logic. #205

Closed
Tracked by #130
arabcoders opened this issue Jul 16, 2022 · 0 comments · Fixed by #208
Closed
Tracked by #130

[WEBHOOKS] Some events should not trigger mark as unplayed logic. #205

arabcoders opened this issue Jul 16, 2022 · 0 comments · Fixed by #208
Assignees
@arabcoders
Labels
bug Something isn't working

Comments

@arabcoders
Copy link
Owner

arabcoders commented Jul 16, 2022 •
edited
Loading

In webhook context,

We noticed that jellyfin itemAdd event triggers mark as unplayed logic even if the state didn't change. jellyfin trigger itemAdd event when file is replaced by any means since 10.8?
@arabcoders arabcoders mentioned this issue Jul 16, 2022
Closed
55 tasks
@arabcoders arabcoders changed the title in webhook context, make sure events like ItemAdd do not reset play state. [WEBHOOKS] Some events should not trigger mark as unplayed logic. Jul 16, 2022
@arabcoders arabcoders self-assigned this Jul 16, 2022
@arabcoders arabcoders added the bug Something isn't working label Jul 16, 2022
arabcoders added a commit that referenced this issue Jul 18, 2022
@arabcoders
Potential fix for #205
2b54e68
@arabcoders arabcoders linked a pull request Jul 18, 2022 that will close this issue
Potential fix some replaced items marking items as unplayed. #208
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arabcoders arabcoders

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Potential fix some replaced items marking items as unplayed. arabcoders/watchstate
1 participant
@arabcoders