-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A major (performance) update on the submodule: srl-zoo; fixes several issues #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vs other than mobile_robot_env.py need to be modify)
ncble
changed the title
A major (performance) update on the submodule: srl-zoo; fix several issues #41~43, #46~49.
A major (performance) update on the submodule: srl-zoo; fixes several issues
Jul 16, 2019
The original version (master) of the whole Toolbox has 18026 lines of code (including srl_zoo). My pull-request has already added and removed +5886/-249, +4145/-1453 (total +10031/-1702 ?) lines of code, thus more than 40% lines of code have been modified. There is no need to be merged to the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the srl_zoo is less popular than robotic-rl-srl, I decided to post the changelog here:
Highlights
Labyrinth
andMobileRobotX
which can run at speed 36,000 FPS (frame-per-second) on 10 threads of Intel CPU i9-9900K (image resolution 128², 20,000 FPS for 224²). Compared to previous MobileRobotGymEnv-v0, it only runs at speed 800 FPS.Fixes #41
Fixes #42
Fixes #43
Fixes #46
Fixes #47
Fixes #48
Fixes #49
Fixes #51
Fixes #53
Fixes #54
Note: Before, we need to modify 8 scripts in order to add one new model, now only two scripts (at most three): models/modules.py and models/my_custom_model.py (see the template models/new_model_template.py)
Changelog
SRL part
Support any image resolution for the entire toolbox (--img-shape="(3,128,128)"), including the DataLoader, Environment, SRL models. Before, the SRL models are not scalable with respect to image shape, and it's not sufficient to modify only the input shape (e.g. need to manually calculate each layers' shape, size, etc). Now, all models function more like keras.
Support adversarial state representation learning. (e.g. GAN)
[New scripts] models/base_trainer.py, models/new_model_template.py, models/gan.py
Better (simpler, ~10 times faster) plots
Support new monitor mode (--monitor) "loss" (before, there is only "pbar" progressbar): monitor losses during training, calculate GTC per epoch.
Support control of number of CPU for dataloader (--num-worker).
Support "anytime training": load the previous trained SRL model weights to continue the training --srl-pre-weights (weights path)
Change validation mechanism to the classic one (i.e. within one epoch: train then valid). Before, we alternate between training and validation mode at batch level.
Support specific GPU number. (by --gpu-num=0, --gpu_num1, etc)
[Remove]: preprocessing/preprocess.py (it's useless), models/custom_layers.py
[Rename] the models/models.py is renamed to models/base_models.py, since it's more intuitive for the outsider. Currently, there are several confusing names "custom_layers.py", "modules.py", "learner.py" "models.py
RL part
Labyrinth-v0
andMobileRobotX-v0
(enable interactive play) which can run at speed 36,000 FPS (frame-per-second) on 10 threads of Intel CPU i9-9900K (image resolution 128², 20,000 FPS for 224²). Compared to previous MobileRobotGymEnv-v0, it only runs at speed 800 FPS.