Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors in file streaming correctly #5

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Handle errors in file streaming correctly #5

merged 1 commit into from
Mar 20, 2018

Conversation

onbjerg
Copy link
Contributor

@onbjerg onbjerg commented Mar 19, 2018

No description provided.

@onbjerg onbjerg requested a review from izqui March 19, 2018 23:36
@onbjerg onbjerg added the bug Something isn't working label Mar 19, 2018
izqui
izqui approved these changes Mar 20, 2018
View reviewed changes
Copy link
Contributor

@izqui izqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@onbjerg onbjerg merged commit 62749ea into master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izqui izqui izqui approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onbjerg @izqui