Implement 'publishVersionIntent' #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernelwhisperer
approved these changes
Apr 6, 2019
Co-Authored-By: sohkai <qisheng.brett.sun@gmail.com>
sohkai
reviewed
Apr 8, 2019
| * Publishes a new version (`version`) of `appId` using storage provider `provider`. | ||
| * | ||
| * If the destination repository does not exist, the intent will be for creating a new | ||
| * repository with an initial version. |
There was a problem hiding this comment.
Is it a lot easier for the CLI to use a single function to do both version publishes as well as repo creations?
Really seems like there's two concerns mixed here (you can immedately tell by the manager being the first argument, but it not being used at all on the "normal" path).
There was a problem hiding this comment.
Not necessarily, I think having something like:
if ( apm.getRepo() ) {
apm.publishVersion()
} else {
apm.publishInitialVersion()
}
is not more difficult, but actually more expressive 👍 (you don't have to guess the magic publishVersion does).
That being said, refactoring this might take some time without adding a lot of value (especially if we want to keep backwards compatibility), so I will open an issue for it.
Co-Authored-By: 0x6431346e <hello@danielconstantin.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a new
publishVersionIntentfunction that returns an aragon.js intent object that can be used to publish a new version using transaction pathing.publishIntentnow usespublishVersionIntentand still generates the direct transaction to publish a version, making the change fully backwards compatible.Closes #13