Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ES6 modules, add tree shaking with parcel & use ipfs file-regular submodule #42

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Use ES6 modules, add tree shaking with parcel & use ipfs file-regular submodule #42

wants to merge 3 commits into from

Conversation

0xGabi
Copy link
Contributor

@0xGabi 0xGabi commented Nov 24, 2019 •
edited by sohkai
Loading

Closes #17

@0xGabi 0xGabi requested a review from sohkai November 24, 2019 01:25
sohkai
sohkai reviewed Dec 11, 2019
View reviewed changes
package.json
}
},
"devDependencies": {
"parcel-bundler": "^1.12.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parcel is not really meant for npm packages, but more suited for bundled applications.

We may want to use microbundle instead.

sohkai
sohkai reviewed Dec 11, 2019
View reviewed changes
Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, maybe we can release this as v4.

I removed this PR closing #23, as it's not really the case. ipfs-http-client/src/files is still quite large.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohkai sohkai sohkai left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use ES6 modules and a tree-shaking bundler
2 participants
@0xGabi @sohkai