Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close low hanging fruit PRs before SDK v7 refactors begin #853

Closed
6 tasks done
theethernaut opened this issue Oct 29, 2019 · 2 comments
Closed
6 tasks done

Close low hanging fruit PRs before SDK v7 refactors begin #853

theethernaut opened this issue Oct 29, 2019 · 2 comments
Assignees

Comments

@theethernaut
Copy link
Contributor

theethernaut commented Oct 29, 2019

Before we begin doing heavy refactors for SDK v7, we want to assimilate PRs that:

  • Are simple enough
  • Are compatible with the general direction of the upcoming refactors
  • Don't add feature / complexity
  • Have value and would be too complicated to include after the refactors have been implemented

PRs included:

@theethernaut theethernaut self-assigned this Oct 29, 2019
@theethernaut
Copy link
Contributor Author

@macor161 I wasn't able to assign you to this issue, not sure why... could you add yourself please?

@sohkai sohkai mentioned this issue Oct 29, 2019
12 tasks
@macor161
Copy link
Contributor

macor161 commented Oct 30, 2019

#845 doesn't seem to be working well. I propose we postpone it until after the refactoring is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants