Displays version on debug = true #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
macor161
approved these changes
Oct 30, 2019
There was a problem hiding this comment.
Works great! Thanks @ajsantander 🙌
I would perhaps move the debugMiddleware function with the other middlewares but we can do this (or find another architecture) during the refactoring.
|
Congrats on merging your first pull request! Aragon is proud of you 🦅 |
0xGabi
pushed a commit
that referenced
this pull request
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #634
This also fixes a TODO comment I found on cli.js, where the argv's wouldn't be printed on debug mode.