Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a detailed error with next steps when cyclic dependencies are found, to resolve #780 #844

Closed
wants to merge 2 commits into from
Closed

Show a detailed error with next steps when cyclic dependencies are found, to resolve #780 #844

wants to merge 2 commits into from

Conversation

dapplion
Copy link
Contributor

🦅 Pull Request

Show a better error when truffle-flattener throws due to cyclic dependencies found. Also, show possible paths to address the problem.

Fixes #780

🚨 Test instructions

✔️ PR Todo

  • Include links to related issues/PRs
  • Update unit tests for this change
  • Update the relevant documentation
  • Clear dependencies on other modules that have to be released before merging this

@dapplion dapplion requested a review from 0xGabi as a code owner October 27, 2019 21:56
0xGabi
0xGabi approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@0xGabi 0xGabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I include the same error handler for the contract deployment task. Other than that LGTM.

Note: we should refactor the flattener functionality.

@eternauta1337 eternauta1337 mentioned this pull request Oct 29, 2019
Closed
6 tasks
@dapplion
Copy link
Contributor Author

I include the same error handler for the contract deployment task. Other than that LGTM.

Note: we should refactor the flattener functionality.

Great! Thank you

@eternauta1337 eternauta1337 mentioned this pull request Oct 31, 2019
Merged
@eternauta1337
Copy link
Contributor

Added some changes manually, so I'm closing this PR in favor or #857

Thanks @dapplion !!!

macor161 pushed a commit that referenced this pull request Oct 31, 2019
@eternauta1337 @macor161
Truffle flattener cyclic dependencies error - re-work on PR #844 (#857)
2de4416 
* Show a detailed error with next steps when cyclic dependencies are found

* Add error handler on contract  deployment task

* Unified truffle flattener cyclic dependency errors

* Add return and array to flatten call
0xGabi pushed a commit that referenced this pull request Oct 31, 2019
@eternauta1337
Truffle flattener cyclic dependencies error - re-work on PR #844 (#857)
4048c2f 
* Show a detailed error with next steps when cyclic dependencies are found

* Add error handler on contract  deployment task

* Unified truffle flattener cyclic dependency errors

* Add return and array to flatten call
@dapplion dapplion deleted the 780_cyclic_deps branch November 1, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xGabi 0xGabi 0xGabi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better error message when we detect a cycle dependency
3 participants
@dapplion @eternauta1337 @0xGabi