New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commands/run): introduce --client-path option #200

Merged
merged 1 commit into from Sep 14, 2018

Conversation

Projects
None yet
2 participants
@PascalPrecht
Copy link
Contributor

PascalPrecht commented Sep 11, 2018

This commit enables users to pass a --client-path to the run command.
The path specifies the location to an already existing installation of the
Aragon client on the local machine, allowing developers to test custom versions
of the app.

Closes #199

@luisivan luisivan requested a review from izqui Sep 11, 2018

@PascalPrecht PascalPrecht force-pushed the PascalPrecht:feat/run/client-path-option branch from 41a6a04 to 8f81623 Sep 12, 2018

@izqui

izqui approved these changes Sep 12, 2018

@izqui

This comment has been minimized.

Copy link
Member

izqui commented Sep 13, 2018

@PascalPrecht Needs rebasing after merging #194

@PascalPrecht PascalPrecht force-pushed the PascalPrecht:feat/run/client-path-option branch from 8f81623 to 22b6fe7 Sep 13, 2018

@PascalPrecht

This comment has been minimized.

Copy link
Contributor

PascalPrecht commented Sep 13, 2018

@izqui done

@izqui

izqui approved these changes Sep 13, 2018

@@ -132,6 +135,7 @@ exports.handler = function ({
appInitArgs,
clientVersion,
clientPort

This comment has been minimized.

@izqui

izqui Sep 13, 2018

Member

Missing a , here

This comment has been minimized.

@PascalPrecht

PascalPrecht Sep 13, 2018

Contributor

Good catch! 👍

Slipped through during rebase.

This comment has been minimized.

@PascalPrecht

PascalPrecht Sep 13, 2018

Contributor

This is now fixed.

feat(commands/run): introduce --client-path option
This commit enables users to pass a `--client-path` to the `run` command.
The path specifies the location to an already existing installation of the
Aragon client on the local machine, allowing developers to test custom versions
of the app.

Closes #199

@PascalPrecht PascalPrecht force-pushed the PascalPrecht:feat/run/client-path-option branch from 22b6fe7 to 18cf20e Sep 13, 2018

@izqui izqui merged commit 7fc0b8a into aragon:master Sep 14, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
license/cla Contributor License Agreement is signed.
Details

@PascalPrecht PascalPrecht deleted the PascalPrecht:feat/run/client-path-option branch Sep 15, 2018

galactusss added a commit to galactusss/aragon-cli that referenced this pull request Jan 5, 2019

feat(commands/run): introduce --client-path option (aragon#200)
This commit enables users to pass a `--client-path` to the `run` command.
The path specifies the location to an already existing installation of the
Aragon client on the local machine, allowing developers to test custom versions
of the app.

Closes aragon#199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment