New prepublish option for apm publish #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xGabi
added
cmd: apm publish
馃挕 feature update
sohkai
reviewed
Jul 5, 2019
| @@ -62,6 +63,34 @@ const installDeps = (cwd, task) => { | |||
| }) | |||
| } | |||
|
|
|||
| const runScriptTask = async (task, scritpName) => { | |||
There was a problem hiding this comment.
A nitpick, the variable here is misspelt.
sohkai
reviewed
Jul 5, 2019
| }) | ||
| .option('prepublish-script', { | ||
| description: 'The npm script that will be run before publishing the app', | ||
| default: 'prepublish', |
There was a problem hiding this comment.
npm's prepublish script is actually kind of deprecated. It would be nice to also fallback to prepublishOnly if that exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 Pull Request
closes #430
New
prepublishoption that run as default theprepublish-scriptspecified before publishing (default:perpublish)Refactor script tasks.
鉁旓笍 PR Todo
Include links to related issues/PRs
Update the relevant documentation
PR to include prepublish script to boilerplates (Include prepublish script聽aragon-react-boilerplate#62)