Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

New prepublish option for apm publish #571

Merged
merged 2 commits into from Jul 3, 2019

Conversation

3 participants
@0xGabi
Copy link
Member

commented Jun 30, 2019

馃 Pull Request

closes #430

New prepublish option that run as default the prepublish-script specified before publishing (default: perpublish)

Refactor script tasks.

鉁旓笍 PR Todo

@0xGabi 0xGabi requested a review from 0x6431346e as a code owner Jun 30, 2019

@0xGabi 0xGabi added this to In progress in Aragon Mesh Team via automation Jun 30, 2019

@0xGabi 0xGabi referenced this pull request Jun 30, 2019

Merged

Include prepublish script #62

@0xGabi 0xGabi moved this from In progress to Review in Aragon Mesh Team Jul 1, 2019

@0x6431346e
Copy link
Member

left a comment

馃挴

@0xGabi 0xGabi merged commit 76c30a3 into aragon:master Jul 3, 2019

3 of 4 checks passed

coverage/coveralls Coverage decreased (-3.3%) to 0.82%
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@0xGabi 0xGabi deleted the 0xGabi:feat/apm-prepublis-task branch Jul 3, 2019

@@ -62,6 +63,34 @@ const installDeps = (cwd, task) => {
})
}

const runScriptTask = async (task, scritpName) => {

This comment has been minimized.

Copy link
@sohkai

sohkai Jul 5, 2019

Member

A nitpick, the variable here is misspelt.

})
.option('prepublish-script', {
description: 'The npm script that will be run before publishing the app',
default: 'prepublish',

This comment has been minimized.

Copy link
@sohkai

sohkai Jul 5, 2019

Member

npm's prepublish script is actually kind of deprecated. It would be nice to also fallback to prepublishOnly if that exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.