-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extracts logic from apm commands #871
Conversation
eac84bf
to
ba17efe
Compare
@0xGabi Let's review this one as a whole once all other sub-PRs are merged |
sdk-v7-refactor-apm & move extract-functions to root
Codecov Report
@@ Coverage Diff @@
## develop #871 +/- ##
===========================================
+ Coverage 10.85% 15.24% +4.38%
===========================================
Files 93 98 +5
Lines 2404 2486 +82
===========================================
+ Hits 261 379 +118
+ Misses 2143 2107 -36
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙌
I think we can merge this to keep progress for the next iteration. Tackling the misc points.
Agree, will review this PR as a whole today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Although it's already merged, looks good to me too. It would need a second iteration to make things consistent and test it as a whole. |
WIP
Commands:
Misc:
Note: discussion about future steps moved #947