Extracts logic from apm commands: grant command #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theethernaut
requested review from
kernelwhisperer and
0xGabi
as code owners
14 tasks
theethernaut
force-pushed
the
sdk-v7-refactor-apm
branch
from
eac84bf
to
ba17efe
Compare
theethernaut
force-pushed
the
sdk-v7-refactor-apm-grant
branch
from
d470153
to
1a4a38b
Compare
0xGabi
requested review from
dapplion
and removed request for
kernelwhisperer
dapplion
suggested changes
Nov 14, 2019
There was a problem hiding this comment.
Looks good! Clean and good namings 🎆. However, I see a bit of abuse of the progressHandler. It should
- be used exclusively for informative updates, not for error handling, and
- only in spots where it can provide valuable information, not after/before every async block.
packages/aragon-cli/test/lib/apm/grantNewVersionsPermission.test.js
Outdated
Show resolved
Hide resolved
dapplion
suggested changes
Nov 20, 2019
|
Thank you @macor161 for addressing the issues, really neat work. I added one extra comment on a separate review regarding the tests |
0xGabi
approved these changes
Nov 21, 2019
macor161
pushed a commit
that referenced
this pull request
Nov 22, 2019
* Enabling verbose in AVA tests * Review: Extracts logic from apm commands: info command (#898) * Extracts logic from apm commands: extract-functions command (#870) * Extracts logic from apm commands: versions command (#891) * Extracts logic from apm commands: packages command (#892) * Extracts logic from apm commands: grant command (#902) * Fix test import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review
Sub PR of #871