wrapper: Allow wrapper to set accounts manually #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohkai
reviewed
Mar 17, 2018
| * @param {Array<string>} accounts | ||
| * @return {void} | ||
| */ | ||
| setAccounts (accounts) { |
There was a problem hiding this comment.
A little bit confused about the type accounts should be; getAccounts() apparently returns a Promise but setAccounts() takes in an array?
There was a problem hiding this comment.
getAccounts returns a promise because it falls back to calling via Web3, which returns a promise.
I will move accounts as an optional parameter to init, but getAccounts will always be a promise.
|
works w tx pathing in sandbox |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #91
Also adds
accountsRPC message, closes #62