New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrapper: Allow wrapper to set accounts manually #93

Merged
merged 4 commits into from Mar 18, 2018

Conversation

Projects
None yet
2 participants
@onbjerg
Contributor

onbjerg commented Mar 16, 2018

Closes #91

Also adds accounts RPC message, closes #62

@onbjerg onbjerg added the type: bug label Mar 16, 2018

@onbjerg onbjerg self-assigned this Mar 16, 2018

@onbjerg onbjerg requested a review from sohkai Mar 16, 2018

* @param {Array<string>} accounts
* @return {void}
*/
setAccounts (accounts) {

This comment has been minimized.

@sohkai

sohkai Mar 17, 2018

Member

A little bit confused about the type accounts should be; getAccounts() apparently returns a Promise but setAccounts() takes in an array?

@sohkai

sohkai Mar 17, 2018

Member

A little bit confused about the type accounts should be; getAccounts() apparently returns a Promise but setAccounts() takes in an array?

This comment has been minimized.

@onbjerg

onbjerg Mar 17, 2018

Contributor

getAccounts returns a promise because it falls back to calling via Web3, which returns a promise.

I will move accounts as an optional parameter to init, but getAccounts will always be a promise.

@onbjerg

onbjerg Mar 17, 2018

Contributor

getAccounts returns a promise because it falls back to calling via Web3, which returns a promise.

I will move accounts as an optional parameter to init, but getAccounts will always be a promise.

onbjerg added some commits Mar 17, 2018

@onbjerg

This comment has been minimized.

Show comment
Hide comment
@onbjerg

onbjerg Mar 18, 2018

Contributor

works w tx pathing in sandbox

Contributor

onbjerg commented Mar 18, 2018

works w tx pathing in sandbox

@sohkai sohkai referenced this pull request Mar 18, 2018

Merged

Set accounts on aragon.js #143

@sohkai

sohkai approved these changes Mar 18, 2018

❤️

@onbjerg onbjerg merged commit 91274b5 into master Mar 18, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@onbjerg onbjerg deleted the accounts branch Apr 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment