Get final converted amount via abi interface #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-hook
commented
Jun 11, 2020
andy-hook
commented
Jun 11, 2020
sohkai
reviewed
Jun 11, 2020
lib/web3-contracts.js
Outdated
| try { | ||
| const transactionReceipt = await ethersProvider.getTransactionReceipt( | ||
| hash | ||
| ) | ||
|
|
||
| return transactionReceipt | ||
| transactionReceipt.logs.forEach(log => { | ||
| const parsedLog = abiInterface.parseLog(log) |
There was a problem hiding this comment.
Just wanted to make sure:
- What happens if that specific log can't be parsed? Is an error thrown or is
parsedLogjust null? - Here, since we control the previous transaction, we can just assume that the first log is going to be the
Transferevent (I believe it is, anyway—there should only be two logs in these claim transactions).
There was a problem hiding this comment.
To answer the first question I look into Ethers code and the library return null if the log can't be parsed: https://github.com/ethers-io/ethers.js/blob/master/utils/interface.js#L388
There was a problem hiding this comment.
Cool—can we double check what happens with the v5 ABI encoder?
There was a problem hiding this comment.
Thanks for looking @0xGabi , I'll log the encoder as an item to check.
andy-hook
force-pushed
the
signing-stepper__logs-via-abi
branch
from
62bb274
to
a4780c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #37 (comment)