Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core(Govern): Add ERC-1271 support #1

Closed
izqui opened this issue Sep 29, 2020 · 0 comments · Fixed by #258
Closed

Core(Govern): Add ERC-1271 support #1

izqui opened this issue Sep 29, 2020 · 0 comments · Fixed by #258
Assignees
@izqui @sohkai
Labels
P1 🔜 'We need to do this ASAP' issues S1: Feature 👨‍🎨 Adding new stuff T0: Core 🌞 Core issues

Comments

@izqui
Copy link
Contributor

izqui commented Sep 29, 2020

No description provided.

@izqui izqui changed the title ERC-1271 support Add ERC-1271 support Sep 29, 2020
@izqui izqui added this to the Beta 1: Mainnet pre-release milestone Oct 9, 2020
@izqui izqui mentioned this issue Oct 9, 2020
Closed
@izqui izqui added P2 👀 'Lets do!' issues S1: Feature 👨‍🎨 Adding new stuff labels Oct 9, 2020
@izqui izqui removed this from the Beta X: Mainnet pre-release milestone Oct 16, 2020
@izqui izqui self-assigned this Oct 16, 2020
@izqui izqui added the T0: Core 🌞 Core issues label Oct 23, 2020
@izqui izqui added P1 🔜 'We need to do this ASAP' issues and removed P2 👀 'Lets do!' issues labels Nov 2, 2020
@izqui izqui changed the title Add ERC-1271 support Core(Govern): Add ERC-1271 support Nov 2, 2020
Evalir added a commit that referenced this issue Dec 3, 2020
@Evalir
Console: Improvement round #1 (#233)
3e76493 
* console: add action pagination + cosmetic changes

* Add formatting for permissions section

* chore: remove unnecesary console log

* console: small improvements to links and general views

* Cosmetic enhancements a-la contraktor

* Add permissions filtering

* Increase delay for actions scheduled

* Handle token approvals

* Console demo statte

* Sort actions, show human readable execution time

* Fix linting / tooling

* Remove logging

* tooling: revert to React, React DOM & React scripts pre-React 17

While it would be great to update to the latest version of React and all
its tooling, there seems to be an issue with typescript versions,
react-scripts and the new JSX transform wreaking havoc on the JSX
checks. While the issue was supposedly fixed here
(facebook/create-react-app#9869), upgrading to
react-scripts 4.0.1 doesn't fix the problem. Neither does upgrading AND
pinning typescript to 4.0.5 so it doesn't overwrite the tsconfig.json
file. Let's wait a few versions ahead for react-scripts so we can be
sure this is fixed.
@sohkai sohkai mentioned this issue Dec 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@izqui izqui

@sohkai sohkai

Labels
P1 🔜 'We need to do this ASAP' issues S1: Feature 👨‍🎨 Adding new stuff T0: Core 🌞 Core issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

govern-core: implement ERC1271 through proxied signature validator aragon/govern
2 participants
@izqui @sohkai