Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utils: ACL.bulk test #216

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Utils: ACL.bulk test #216

merged 2 commits into from
Nov 11, 2020

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Nov 10, 2020

closes #13

@nivida nivida added P2 👀 'Lets do!' issues T0: Core 🌞 Core issues S5: Test 👨‍🍳 Make it rock solid labels Nov 10, 2020
@nivida nivida requested a review from 0xGabi November 10, 2020 12:20
@CLAassistant
Copy link

CLAassistant commented Nov 10, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

0xGabi
0xGabi approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@0xGabi 0xGabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me!

Maybe we could include one more tests were we bulk a few actions and assert the right number of events are emitted and on the correct order.

@0xGabi
Copy link
Contributor

0xGabi commented Nov 10, 2020 •
edited
Loading

I also notice that lints are not right. Pierre include a git hook with husky for the GovernLib maybe we should standardize that for every package on the monorepo. cc @bpierre

@nivida nivida merged commit 45fd95f into master Nov 11, 2020
@nivida nivida deleted the test/mini-acl-bulk branch November 11, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xGabi 0xGabi 0xGabi approved these changes

Assignees
No one assigned
Labels
P2 👀 'Lets do!' issues S5: Test 👨‍🍳 Make it rock solid T0: Core 🌞 Core issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit tests for MiniACL.bulk
3 participants
@nivida @CLAassistant @0xGabi