Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement simple improvement (no testing) #463

Closed
wants to merge 1 commit into from
Closed

implement simple improvement (no testing) #463

wants to merge 1 commit into from

Conversation

Rekard0
Copy link
Contributor

@Rekard0 Rekard0 commented Sep 12, 2023 •
edited by jira bot
Loading

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task: OS-614

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

Rekard0
Rekard0 commented Sep 13, 2023
View reviewed changes
packages/subgraph/schema.graphql
Comment on lines +213 to +215
"we can use the following attributes to create one-to-many between Dao or PluginRepo to Permission"
dao: Dao
pluginRepo: PluginRepo
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is a good idea? or it might create future scaling problems

@Rekard0
Copy link
Contributor Author

Rekard0 commented Sep 22, 2023

will be implemented in #469

@Rekard0 Rekard0 closed this Sep 22, 2023
@novaknole novaknole deleted the POC/OS-614-improve-permission-indexing branch November 5, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
subgraph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Rekard0