Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: removed deprecated SignatureValidatorSet event from subgraph #473

Merged
merged 2 commits into from
Oct 24, 2023
Merged

refactor: removed deprecated SignatureValidatorSet event from subgraph #473

merged 2 commits into from
Oct 24, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented Sep 27, 2023 •
edited
Loading

Description

Task: OS-724

Type of change

See the framework lifecylce in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • The SignatureValidatorSet was not used anywhere so removal does not qualify as a breaking change

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@heueristik heueristik force-pushed the feature/deprecate-set-signature-validator-events branch from 8f11920 to fa139f9 Compare October 20, 2023 08:50
@heueristik heueristik marked this pull request as ready for review October 20, 2023 09:11
@heueristik heueristik force-pushed the feature/deprecate-set-signature-validator-events branch from eaefff6 to fa139f9 Compare October 20, 2023 09:30
@heueristik heueristik changed the title refactor: removed deprecated SignatureValidatorEvent event from subgraph refactor: removed deprecated SignatureValidatorSet event from subgraph Oct 20, 2023
@heueristik heueristik force-pushed the feature/deprecate-set-signature-validator-events branch from 858bf26 to 43a9f6d Compare October 23, 2023 09:56
@heueristik heueristik merged commit c1c055d into develop Oct 24, 2023
13 checks passed
@heueristik heueristik deleted the feature/deprecate-set-signature-validator-events branch October 24, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josemarinas josemarinas josemarinas approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

@mathewmeconry mathewmeconry Awaiting requested review from mathewmeconry

Assignees
No one assigned
Labels
contracts subgraph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heueristik @Rekard0 @josemarinas