Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong import, missing await, incorrect comment #526

Merged
merged 3 commits into from
Feb 6, 2024
Merged

fix: wrong import, missing await, incorrect comment #526

merged 3 commits into from
Feb 6, 2024

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented Jan 30, 2024 •
edited
Loading

Description

Task ID: OS-1013

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.

@heueristik heueristik marked this pull request as ready for review February 6, 2024 09:58
@heueristik heueristik changed the title fix: various fixes fix: wrong import, missing await, incorrect comment Feb 6, 2024
@heueristik heueristik merged commit c559bfe into develop Feb 6, 2024
18 checks passed
@heueristik heueristik deleted the feature/fixes branch February 6, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordaniza jordaniza jordaniza approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

@josemarinas josemarinas Awaiting requested review from josemarinas

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heueristik @Rekard0 @jordaniza