Staking #1
Merged
Staking #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because solidity-coverage don't support them.
To avoid reentrancy. Although staking token should be safe, it's better to have it this way. Besides, it's better to have require first too.
For consistency with check that amount is not zero when creating a lock. Besides it will avoid having 'garbage' in active lock ids array, which would make operations like checking unlocked balance more expensive.
sohkai
reviewed
Mar 22, 2019
contracts/test/TestImports.sol
Outdated
|
|
||
| contract TestImports { | ||
| constructor() public { | ||
| // to avoid lint error |
There was a problem hiding this comment.
We can upgrade solium to eth-lint and use the new ignore syntax: https://github.com/aragon/aragon-apps/blob/master/apps/voting/contracts/test/TestImports.sol#L25
| @@ -0,0 +1,218 @@ | |||
| // Copied from https://github.com/OpenZeppelin/openzeppelin-solidity/blob/a9f910d34f0ab33a1ae5e714f69f9596a02b4d91/contracts/token/ERC20/StandardToken.sol | |||
There was a problem hiding this comment.
The token mocks used by aragon-apps are now available as part of @aragon/test-helpers
| "license": "(GPL-3.0-or-later OR MIT)", | ||
| "repository": "https://github.com/aragon/staking", | ||
| "devDependencies": { | ||
| "@aragon/apps-shared-migrations": "1.0.0", |
There was a problem hiding this comment.
What do you think about just adding the file?
package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@aragon/test-helpers": "^1.0.1", | ||
| "@aragon/os": "^4.0.1", |
| console.log(1) | ||
| const echidnaStaking = await EchidnaStaking.new() | ||
| //console.log(echidnaStaking.constructor._json) | ||
| console.log(2, echidnaStaking.address) |
There was a problem hiding this comment.
I assume we could clean this up a bit, or remove it (seems like we should be using the .sh version?)
There was a problem hiding this comment.
Nice job @bingen! Looks really good, left some suggestions and questions as well, and some other cosmetic stuff. Let me know if I can help addressing those comments that you agree if it makes sense 🤗
Co-Authored-By: bingen <bingentxu@gmail.com>
* Optimize some gas in checkpointing library * Address PR #4 comments
bingen
pushed a commit
that referenced
this pull request
Apr 12, 2019
bingen
pushed a commit
that referenced
this pull request
Apr 15, 2019
- Add getLatestValue for Checkpointing - Optimize Checkpointing binary search - Add max locks per account - Move stakedhistory into Account struct
bingen
pushed a commit
that referenced
this pull request
Apr 15, 2019
- Add getLatestValue for Checkpointing - Optimize Checkpointing binary search - Add max locks per account - Move stakedhistory into Account struct
- Add getLatestValue for Checkpointing - Optimize Checkpointing binary search - Add max locks per account - Move stakedhistory into Account struct
facuspagnuolo
approved these changes
Apr 29, 2019
| // assuming a safety max gas of ~6M, 5,000 locks is a safe value to avoid OOG issues | ||
| // it's a sanity check, because as lock uses unlockedBalanceOf, and it's the most expensive | ||
| // it's unlikely that locks enough could be created to brick the account | ||
| uint256 internal constant MAX_LOCKS = 5000; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.