Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hookify all the things #136

Closed
sohkai opened this issue Mar 15, 2018 · 5 comments
Closed

Hookify all the things #136

sohkai opened this issue Mar 15, 2018 · 5 comments

Comments

@sohkai
Copy link
Contributor

sohkai commented Mar 15, 2018

E.g. SidePanel could pass down opened via a render prop, most HOCs should have a render prop equivalent exposed.

@stale
Copy link

stale bot commented Jun 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for contributing to Aragon! 🦅

@stale stale bot added the abandoned label Jun 9, 2019
@bpierre bpierre removed the abandoned label Jun 10, 2019
@bpierre bpierre changed the title Render prop all the things Hookify all the things Jun 10, 2019
@bpierre
Copy link
Contributor

bpierre commented Jun 10, 2019

Updated the title to have hooks instead: a render prop component can be done in one line from a hook (but a hook can not be made from a render prop component).

I think we should even stop exporting render props for new things, to avoid any confusion.

@bpierre
Copy link
Contributor

bpierre commented Jun 10, 2019

Closing since https://github.com/aragon/aragon-ui/issues/136 exists already

@bpierre bpierre closed this as completed Jun 10, 2019
@sohkai
Copy link
Contributor Author

sohkai commented Jul 3, 2019

Haha I think this is #136 :).

@sohkai sohkai reopened this Jul 3, 2019
@bpierre
Copy link
Contributor

bpierre commented Jul 3, 2019

haha sorry I meant https://github.com/aragon/aragon-ui/issues/357

@sohkai sohkai closed this as completed Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants