Markdown rendering / Normalized Html styling

[corydickson]

Addresses issue #386

I had to update the rollup config with a JSON plugin due to a failed installation. Let me know if you are able to reproduce.

Also since we are using jsx everywhere I don't think we'll need to sanitize the input.

[welcome]

Thanks for opening this pull request! Someone will review it soon 🔍

[CLAassistant]

All committers have signed the CLA.

[bpierre]

Awesome, thank you @Gh1dra! 🎉

I left a few comments, let me know what you think! 🤗

[corydickson]

@bpierre @chadoh Thank you both for your review! Let me know if there is anything I didn't address from the original issue.

Currently, Travis is failing due to the rollup config: https://travis-ci.org/aragon/aragon-ui/jobs/553950501

Here is the new issue: #400

[corydickson]

@bpierre Is there anything I can do to help push this over the line? Are there any updates using the new design system that you'd like to see incorporated?

[bpierre]

Hi @Gh1dra, sorry about the super long wait. We are going to review the last changes during the next week or so.

Are there any updates using the new design system that you'd like to see incorporated?

Ideally yes! Would you mind moving these changes on top of newstyle rather than master?

Some changes that will be needed for 1.0:

• Replace theme by useTheme(), and make sure all the colors are coming from it (so that it’s ready for the dark theme).
• Replace font by textStyle().
• Use GU (e.g. ${2 * GU}px rather than 16px.
• Replace SafeLink by Link.

Let me know if you have any question, I am also bpierre on https://aragon.chat :-)

[corydickson]

@bpierre Sorry for the delay, rollup is still giving me issues on my local machine but seems to be passing your build pipeline. Edit: I'm wondering why this rollup-json plugin is now suddenly a requirement... If this looks good I'll squash the prior commits and add @chadoh as an author

[bpierre]

Hey @corydickson, thanks for this, and sorry for the delay!

I added a few commits:

• Move to markdown-to-jsx, which is lighter than react-markdown (5kb vs. 20kb), and doesn’t have the
  bundling issues that react-markdown has.
• Fix the theme colors.
• Use <Link /> and <Checkbox /> in the rendered markdown.
• Tweak NormalizedHtml styles.
• Add documentation.
• Other tweaks, coding style, prop types etc.

I think it is ready to be merged soon :-)

[corydickson]

@bpierre Thanks! Do you want to handle to rebase then? Want to be sure @chadoh gets authorship / green squares :)

[bpierre]

@corydickson I only merged master in, using merge commits! For the autorship issue, did you want to squash your previous commits to make @chadoh the author? If that’s the case feel free to do so, I’ll wait for it before merging. Note that we always squash & merge our PRs, so all the commits here will appear as a single commit on master. Let me know!

[corydickson]

So when I try to rebase it makes me the author of all the child commits from 728553e onward... let's just add: Co-authored-by: Chad Ostrowski <hi@chadoh.com> at the end when you squash after review sorry for the confusion 😅

[sohkai]

A couple comments and we're having an offline discussion about the unstyled prop, but otherwise, LGTM!