Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataView: ensure there is only one empty state displayed at a time #712

Merged
merged 2 commits into from
Feb 9, 2020
Merged

DataView: ensure there is only one empty state displayed at a time #712

merged 2 commits into from
Feb 9, 2020

Conversation

bpierre
Copy link
Contributor

@bpierre bpierre commented Feb 9, 2020

No description provided.

rperez89
rperez89 approved these changes Feb 9, 2020
View reviewed changes
Copy link
Contributor

@rperez89 rperez89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now LGTM!

@bpierre bpierre merged commit 4563ddb into master Feb 9, 2020
@bpierre bpierre deleted the dataview-unique-empty-state branch February 9, 2020 20:02
corydickson pushed a commit to corydickson/aragon-ui that referenced this pull request Apr 7, 2020
@bpierre @corydickson
DataView: ensure there is only one empty state displayed at a time (a…
46c134b 
…ragon#712)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rperez89 rperez89 rperez89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bpierre @rperez89