-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @testing-library/react #732
Conversation
Thanks for taking a shot at this @Jfelix61!
Actually, it is! It's here: |
Great I'll be checking it and see what could be going wrong. |
Hi @Jfelix61, thanks for working on this! I added a few commits to sync the branch with |
Thanks for this @bpierre! I'll keep adding tests. |
Hey @Jfelix61! I was wondering if we should merge the setup already, and add the tests in another PR. What do you think? |
I think the same, that way we can keep adding tests in different PRs. |
Awesome, let’s merge it then! 🎉 |
Great! |
Changes
Badge
andButton
Current problem
use-inside
package makesButton
test fail. It seems to be an issue with how it is bundled with commonjs (perhaps its entry point?). Tried compiling it with Babel however it doesn't seem to solve the issue. Since the library is not available in Github I will have to leave for the maintainers at Aragon to check on it.Aside from this problem,
Badge
test is working fine and tests can be written for it.