Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @testing-library/react #732

Merged
merged 5 commits into from
Apr 6, 2020
Merged

Conversation

JoseRFelix
Copy link
Contributor

@JoseRFelix JoseRFelix commented Mar 8, 2020

Changes

  • Added react-testing-library
  • Added initial tests for Badge and Button

Current problem

use-inside package makes Button test fail. It seems to be an issue with how it is bundled with commonjs (perhaps its entry point?). Tried compiling it with Babel however it doesn't seem to solve the issue. Since the library is not available in Github I will have to leave for the maintainers at Aragon to check on it.

Aside from this problem, Badge test is working fine and tests can be written for it.

@sohkai
Copy link
Contributor

sohkai commented Mar 21, 2020

Thanks for taking a shot at this @Jfelix61!

Since the library is not available in Github

Actually, it is! It's here: use-inside.

@JoseRFelix
Copy link
Contributor Author

Actually, it is! It's here: use-inside.

Great I'll be checking it and see what could be going wrong.

@bpierre
Copy link
Contributor

bpierre commented Mar 31, 2020

Hi @Jfelix61, thanks for working on this! I added a few commits to sync the branch with master and to use CommonJS modules. It should work now, let me know if I can help with anything!

@JoseRFelix
Copy link
Contributor Author

Thanks for this @bpierre! I'll keep adding tests.

@bpierre
Copy link
Contributor

bpierre commented Apr 6, 2020

Hey @Jfelix61! I was wondering if we should merge the setup already, and add the tests in another PR. What do you think?

@JoseRFelix
Copy link
Contributor Author

Hey @Jfelix61! I was wondering if we should merge the setup already, and add the tests in another PR. What do you think?

I think the same, that way we can keep adding tests in different PRs.

@bpierre
Copy link
Contributor

bpierre commented Apr 6, 2020

Awesome, let’s merge it then! 🎉

@JoseRFelix
Copy link
Contributor Author

Great!

@bpierre bpierre changed the title [WIP] Add testing Add @testing-library/react Apr 6, 2020
@bpierre bpierre merged commit 942c393 into aragon:master Apr 6, 2020
@welcome
Copy link

welcome bot commented Apr 6, 2020

Congrats on merging your first pull request! Aragon is proud of you 🦅 Eagle gif

@bpierre bpierre mentioned this pull request Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants