Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion: Always display border for expanded content #741

Merged
merged 5 commits into from
Apr 1, 2020

Conversation

rperez89
Copy link
Contributor

@rperez89 rperez89 commented Apr 1, 2020

Screen Shot 2020-04-01 at 11 45 28 AM

This PR closes #703

@auto-assign auto-assign bot requested a review from bpierre April 1, 2020 14:47
@Evalir Evalir changed the title Accordion: Always display borde for expanded content Accordion: Always display border for expanded content Apr 1, 2020
Copy link
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

I added one change to prevent a double border to appear in some cases: https://github.com/aragon/aragon-ui/pull/741/commits/cc60201f8696f12717f00ebed37e2e0412b4464d#diff-0fbd00e0f783364ba190e36b6ace95c4R402

All good otherwise!

@bpierre bpierre merged commit 7fe3a0f into aragon:master Apr 1, 2020
corydickson pushed a commit to corydickson/aragon-ui that referenced this pull request Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accordion: always display the border
2 participants