Slider: Add onTouchStart to slider circle #745
Conversation
src/components/Slider/Slider.js
Outdated
| @@ -205,7 +208,6 @@ const Bar = styled(animated.div)` | |||
| ` | |||
|
|
|||
| const HandleClip = styled.div` | |||
| pointer-events: none; | |||
There was a problem hiding this comment.
I think this change only should be enough? But a problem it introduces is that it makes the entire HandleClip area clickable (which is bigger than the slider + its padding).
There was a problem hiding this comment.
I think this change only should be enough? But a problem it introduces is that it makes the entire
HandleCliparea clickable (which is bigger than the slider + its padding).
yeah, do you have some suggestion about how to tackle that?
There was a problem hiding this comment.
I was checking and yes, I think there is a simple fix! We could leave the pointer-events: none here, but add pointer-events: auto on the actual handle (the animated.div), and that seems to be enough from my tests. Let me know if you see any issue with it!
This PR closes #718