Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer: documentation about maxUnits prop #746

Merged
merged 4 commits into from
Apr 3, 2020

Conversation

rperez89
Copy link
Contributor

@rperez89 rperez89 commented Apr 2, 2020

This PR closes #716

@rperez89 rperez89 requested a review from bpierre April 2, 2020 19:35
Co-Authored-By: Enrique Ortiz <enrique@aragon.one>
Copy link
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions, all good otherwise!

src/components/Timer/README.md Outdated Show resolved Hide resolved
src/components/Timer/README.md Outdated Show resolved Hide resolved
rperez89 and others added 2 commits April 3, 2020 12:59
Co-Authored-By: Pierre Bertet <hello@pierre.world>
Co-Authored-By: Pierre Bertet <hello@pierre.world>
@bpierre bpierre merged commit d90ab13 into aragon:master Apr 3, 2020
corydickson pushed a commit to corydickson/aragon-ui that referenced this pull request Apr 7, 2020

| Type | Default value |
| ------------ | ------------- |
| `Number` | `-1` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick: it looks like we could align this table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timer: document maxUnits
4 participants